-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mock attestation #82
Mock attestation #82
Conversation
The use of the Ordinarily it's best with BASH scripts to define them such that it's clear where to trigger them from (i.e. from which folder to call them) and use relative paths as far as possible. If you need to expand a relative path to an absolute one, then there are BASH utilities/shell commands that can assist with that. |
Good point! Unfortunately we currently require |
Co-authored-by: Shoaib Ahmed <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the rust code looks good. I could not test the listen script because the tx was failing with
"raw_log": "failed to execute message; message index: 0: Error parsing into type transfers_contract::msg::ExecuteMsg: Invalid type: execute wasm contract failed",
I tried to copy exactly what I had in my listen.sh
script as it handles some errors in the main
version, but it bugged out because it expected something different.
I think listen.sh
needs a similar check for MOCK_SGX
as relayer.sh
has. let me know what you think
I have a slight preference for merging this PR without this change and later adding this to #96 (after merging these changes) because IIUC, update attestation is working well there, so it'll be easier to test. 🙏 |
Okay I agree, we can save the fix for I ran the test with the MOCK_SGX and it worked, but now I did not pass the flag and I am running gramine normally, and I am getting this error:
Any ideas? |
When do you see this error? As soon as the enclave starts? Or at the time of handshake? Also, if you did a |
MOCK_SGX was already unset! here is where it fails:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good lets merge
Closes: #14
To test please follow the app/transfers/README.md.